Improve Opcode statistics #1030
Open
+313 −49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
They're similar, but not the same
Owner
| Thanks for the PR, I'll take a look soon. Don't worry about the failing tests, there's an issue with the PHP 8.3 and 8.4 containers at the moment. |
Contributor Author
| Added something back from our prototype tool, to allow to see server limits, even if the statistics cannot be fetched. |
Contributor Author
| Adding some screenshots for reference Regular display When no stats are avaliable Opcache installed, but not enabled And there's a similar text as Object Cache, which is displayed when there's no extension installed, suggesting to ask the host to enable |
msaggiorato force-pushed the feature/qm-cache-info branch from 75a74ec to d9155b5 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a bit of information about Opcode cache. We've been dealing at our company with performance issues regarding opcache and it's configuration on some customer's sites, and wanted to contribute back our learnings by allowing people (and hosts most importantly) to be able to identify problems related to this.
APC is legacy, for which we had to scout for information and get basic cache hit. Not sure how much is it actively used, but nothing should break there.
For OPCache, I've added a bunch of information to the overview tab. Mainly the cache hits for the current request (opcache provides statistics for the whole lifecycle of the FPM process), and also several memory/limits indicators.
Tried to keep UX similar to the rest of QM, hopefully not disturbing anything.
There is a change in function names (due to untying object cache stats from opcode cache stats). I opted for the small refactor in order to keep things clean.