TurboStreamEncoder: redefine accept_header method #760
+2 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since the `action_dispatch_integration_test` hook is invoked for each integration test, the whole `TurboStreamEncoder` is (re)defined many times. Ideally, I think, `@encoders[:turbo_stream]` should be set once, but since `RequestEncoder` does not expose straightforward API to check if an encoder is registered, we'd have to use something like ```ruby ActionDispatch::RequestEncoder::IdentityEncoder === ActionDispatch::RequestEncoder.encoder(:turbo_stream) ``` which is not handy. NB: requiring AS is not necessary -- we can use the self-alias trick instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the
action_dispatch_integration_testhook is invoked for each integration test, the wholeTurboStreamEncoderis (re)defined many times.Ideally, I think,
@encoders[:turbo_stream]should be set once, but sinceRequestEncoderdoes not expose straightforward API to check if an encoder is registered, we'd have to use something likewhich is not handy.
NB: requiring AS is not necessary -- we can use the self-alias trick instead