Commit to ruby@2.6 support #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seanpdoyle force-pushed the issue-861 branch 9 times, most recently from f4b2c14 to deb4f33 Compare 
Member
| Thanks @seanpdoyle. It seems that 2.X tests are still failing. |
seanpdoyle force-pushed the issue-861 branch from deb4f33 to 41e5ced Compare seanpdoyle force-pushed the issue-861 branch 3 times, most recently from 0e1cd60 to 551bf1d Compare 
Closes [hotwired#681][] First, remove `ruby@3.0` syntax including `...` arguments and end-less method definitions. Next, add `ruby@2.6` and `ruby@2.7` to the CI matrix along with `rails@7.1`. [hotwired#681]: hotwired#681
Contributor Author
| @jorgemanrubia I've restored CI to pass for There's a few 2.x specific conditionals, but they can be removed once the final minor release supporting 2.x is cut. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #681
First, remove
ruby@3.0syntax including...arguments and end-lessmethod definitions.
Next, add
ruby@2.6andruby@2.7to the CI matrix along withrails@7.1.