add frame fragmentation support (continuation) #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I have a bug in first commit, when bis.read(byte[]) reads array not fully. So i bring you version with for loop. Now it seems to work fine. |
| I used the frame fragmentation support in my own code. This worked very well and saved me from developping it on my own. Please consider commiting it to your repository ! |
| guys any updates on this PR? |
| Hey folks thanks for looking into this. That fragment support was one of main things I wanted to do when I developed this library, but due to the lack of time I wasn't able to do it. I'm reactivating my work on this library so I will set up an Apache Tomcat server to test it as soon as possible with many test cases |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Apache Tomcat server cuts responce into frames with size up to 8192 bytes. So i can't receive responce in a single frame and i wrote some piece of code to be able receive multiple frames in one message.