Skip to content

Docs: Update and refactor release workflow recipe #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

Docs: Update and refactor release workflow recipe #2498

merged 2 commits into from
Oct 21, 2020

Conversation

@silvenon
Copy link
Contributor

@silvenon silvenon commented Oct 9, 2020 •
edited
Loading

🔥 🔥 🔥

  • infer version bump from commits
  • make release commit message adhere to Conventional Commits
  • read GitHub personal access token from git-ignored .env file
  • functions instead of gulp.task
  • eliminate usage of gulp plugins
  • improve readability with execa and pify

I like this recipe because it can be used as inspiration even by those who want to build something completely different.

Ref. #2164.
@silvenon
Copy link
Contributor Author

silvenon commented Oct 9, 2020

The only piece of functionality that I didn't try to test is githubRelease, but I didn't change it, so I'm assuming that it works.
@silvenon silvenon force-pushed the docs/update-release-recipe branch from 0bcb5f8 to 8222ed9 Compare October 9, 2020 21:41
phated
phated requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is looking really good, but I had a few questions/comments.

Also, once you finish up a recipe, please add the Frontmatter like the other docs so it will be pulled in when I publish the website. Thanks!
@silvenon
Docs: Update and refactor release workflow recipe
d2315c5 
- infer version bump from commits - make release commit message adhere to Conventional Commits - read GitHub personal access token from git-ignored `.env` file - functions instead of `gulp.task` - eliminate usage of gulp plugins - improve readability with `execa` and `util.promisify`
@silvenon silvenon force-pushed the docs/update-release-recipe branch from 8222ed9 to d2315c5 Compare October 18, 2020 08:44
@silvenon silvenon requested a review from phated October 18, 2020 08:47
@silvenon
Copy link
Contributor Author

silvenon commented Oct 18, 2020 •
edited
Loading

I forgot to ask, what frontmatter are you referring to? 🤔
@silvenon
Copy link
Contributor Author

silvenon commented Oct 18, 2020

Oh, I see the frontmatter now, I'll add it as soon as I figure out which values to add.
phated
phated requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an inline suggestion for the frontmatter, and I also shrunk the name of the recipe.
@silvenon @phated
Update docs/recipes/automate-release-workflow.md
ebfb0d8 
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@silvenon
Copy link
Contributor Author

silvenon commented Oct 20, 2020

Got it! Is that it, then?
phated
phated approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! This looks great! Thank you 😄
@phated phated merged commit 6e56ed8 into gulpjs:master Oct 21, 2020
@phated
Copy link
Member

phated commented Oct 21, 2020

Looks awesome! https://gulpjs.com/docs/en/recipes/automate-releases

Thanks again!
@silvenon silvenon deleted the docs/update-release-recipe branch October 22, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@silvenon @phated