- Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable DataLoader chaining (nesting) #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ted/chained DataLoader calls
Contributor
Test Results 315 files 315 suites 2m 26s ⏱️ Results for commit c9a3ff3. ♻️ This comment has been updated with latest results. |
bbakerman reviewed Mar 30, 2025
src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
bbakerman reviewed Mar 30, 2025
Closed
Hc747 reviewed Apr 1, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
Hc747 reviewed Apr 1, 2025
bbakerman reviewed May 1, 2025
bbakerman reviewed May 1, 2025
src/main/java/graphql/execution/DataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
bbakerman reviewed May 1, 2025
bbakerman reviewed May 1, 2025
...main/java/graphql/execution/instrumentation/dataloader/DataLoaderDispatchingContextKeys.java Outdated Show resolved Hide resolved
bbakerman reviewed May 1, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Show resolved Hide resolved
bbakerman reviewed May 1, 2025
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Outdated Show resolved Hide resolved
bbakerman reviewed May 1, 2025
...on/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategyWithDeferAlwaysDispatch.java Outdated Show resolved Hide resolved
bbakerman reviewed May 1, 2025
bbakerman reviewed May 1, 2025
bbakerman reviewed May 1, 2025
src/test/groovy/graphql/execution/instrumentation/dataloader/DataLoaderPerformanceTest.groovy Show resolved Hide resolved
bbakerman reviewed May 1, 2025
...main/java/graphql/execution/instrumentation/dataloader/DataLoaderDispatchingContextKeys.java Outdated Show resolved Hide resolved
bbakerman requested changes May 1, 2025
Member
bbakerman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change for tests
bbakerman reviewed May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
enabling scheduling of nested/chained DataLoader calls