fix(deps): update graphql-java to v20.0.0 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I think we can align also the DataLoaderDispatcherInstrumentationState class since the graphql-java counterpart was updated with some tweeks |
oliemansm approved these changes Mar 13, 2023
oliemansm approved these changes Mar 13, 2023
| @federicorispo Apparently it won't run the workflow because it took me too long to review. Could you pull in latest changes to try to force an update? |
To update graphql-java to version 20.0.0 some changes are necessary: - the signature of DataLoaderDispatcherInstrumentation methods now have the InstrumentationState parameter. The ConfigurableDispatchInstrumentation is aligned to these changes - The SimpleInstrumentation is replaced by SimplePerformantInstrumentation. Now all the codebase uses the new class
federicorispo force-pushed the fix/bump-graphql-java-dependency branch from 36fcbf3 to 592c6bc Compare | @oliemansm Aligned the branch with master |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To update graphql-java to version 20.0.0 some changes are necessary: