Skip to content

Address #630 #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2024
Merged

Address #630 #631

merged 3 commits into from
Apr 16, 2024

Conversation

lol768
Copy link
Contributor

@lol768 lol768 commented Apr 3, 2024 •
edited
Loading

See #630
@lol768
Copy link
Contributor Author

lol768 commented Apr 3, 2024 •
edited
Loading

This works when I publish the package locally, now, and reference it in a net8.0 project:

image

It still continues to work in netstandard2.0 projects, but the IDE understandably doesn't know what the stub attribute means/is under these circumstances.
@rose-a
Copy link
Collaborator

rose-a commented Apr 4, 2024

Hi, thanks for the contribution... please allow me some time for review, I'll hopefully manage to have a look at it within the next few days...
rose-a
rose-a requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@rose-a rose-a left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute should be added to the extension methods directly accepting a query string, too.

https://github.com/graphql-dotnet/graphql-client/blob/master/src/GraphQL.Client.Abstractions/GraphQLClientExtensions.cs
@lol768 lol768 requested a review from rose-a April 4, 2024 09:38
@rose-a rose-a merged commit 875520a into graphql-dotnet:master Apr 16, 2024
@lol768
Copy link
Contributor Author

lol768 commented Apr 16, 2024

Thanks for reviewing @rose-a 🙂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@lol768 @rose-a