experimental: change time-range behavior #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-project-automation bot moved this to 📬 Triage in Plugins Platform / Grafana Community 
grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community 
gabor force-pushed the gabor/change-time-range branch 2 times, most recently from 2b83029 to 10f4b60 Compare 
gabor force-pushed the gabor/change-time-range branch from 10f4b60 to 5cb7a84 Compare 
dafydd-t reviewed Nov 18, 2025
| return bq, err | ||
| } | ||
| | ||
| fixedBytes, err := deleteTimeRangeFromQueryJSON(bytes) |
Contributor
There was a problem hiding this comment.
Maybe a note on here that we recognise it is inefficient, and why we chose to do it this way?
Contributor Author
There was a problem hiding this comment.
good point, i added a comment there 👍
github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
(part of #1419)
when a data source request is sent to Grafana, it may contain multiple queries in it. in certain scenarios, we permit to have per-query time-ranges.
originally this was done using the
timeRangejson attribute name. but then we realized some existing plugins have certain assumptions about that field, and that field should not exist in the JSON, to provide compatibility. so we switched from the nametimeRangeto_timeRange.but this causes other complications, so we decided to go with another approach:
timeRangenametimeRangedoes not appear inbackend.DataQuery.JSON