backend: fix unmarshaling empty refids #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gabor requested review from andresmgot, oshirohugo and wbrowne and removed request for a team 
gabor force-pushed the gabor/fix-empty-refid branch from 4e6a25d to af88ffa Compare 
wbrowne reviewed Jan 8, 2025
| l2Field := iter.ReadObject() | ||
| for { | ||
| // the response may have an empty-string refId. this is not allowed, | ||
| // but it may happen, and we want to be able to handle the case. |
Contributor
There was a problem hiding this comment.
but it may happen, and we want to be able to handle the case.
Out of curiosity, how can this currently happen? Do we need validation elsewhere?
Contributor
There was a problem hiding this comment.
+1, we are removing the error here, therefore making having an empty refId valid. Is that what we want? From the issue description it appears that the goal is to return a meaningful error message, not remove the error.
Contributor
There was a problem hiding this comment.
Clarified offline that we want to actually avoid the error here.
andresmgot approved these changes Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #1177
sometimes a response in a
backend.QueryDataResponsehas no refId (the refId is"").this is technically not allowed, but we need to be able to handle the situation, otherwise we just error out with a cryptic error message.