fix: do a quick check if the application runs on GCP #4163
Merged
+55 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The check whether the application runs on GCP did not use a timeout. This introduces a default 500ms timeout for that check. Fixes googleapis/java-spanner-jdbc#2250
product-auto-label bot added size: s 
surbhigarg92 approved these changes Oct 13, 2025
surbhigarg92 added the do not merge google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java Outdated Show resolved Hide resolved
surbhigarg92 requested changes Oct 13, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java Outdated Show resolved Hide resolved
product-auto-label bot added size: m surbhigarg92 force-pushed the quick-check-is-running-on-gcp branch from beafb68 to 7194be6 Compare 
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java Outdated Show resolved Hide resolved
olavloite commented Oct 13, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java Show resolved Hide resolved
surbhigarg92 approved these changes Oct 13, 2025
surbhigarg92 removed the do not merge olavloite commented Oct 13, 2025
sakthivelmanii approved these changes Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The check whether the application runs on GCP did not use a timeout. This introduces a default 500ms timeout for that check.
Fixes googleapis/java-spanner-jdbc#2250