Skip to content

Conversation

@nimanthadilz
Copy link
Contributor

@nimanthadilz nimanthadilz commented Nov 4, 2025

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
The detailed output of agent evaluations is not readable due to rows in the table getting wrapped. This happens when there are long text values in cells.

508807185-9e8fe1c3-d04a-43dd-acf9-0befaa1b247d

Solution:
Existing code uses tabulate python package to format the table. We can set a maximum column width using maxcolwidths parameter. I have set it to 25.

After the fix:
508810179-b91c5bca-fb43-480b-90ff-bca2e909417c

Testing Plan

I have manually tested if the output is properly displayed after changes. Please let me know if any unit tests can be added for this.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.
image

Manual End-to-End (E2E) Tests:

  1. Create a simple agent using adk (preferably an agent that outputs a long text).
  2. Create an evalset for this agent.
  3. Run the evalset with print_detailed_results option and check if the output is properly displayed.

If you want a quick setup for testing this, I have a sample repo with an agent and an evalset here. You will have to manually build & install the fixed adk version to test it.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.
@google-cla
Copy link

google-cla bot commented Nov 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the eval [Component] This issue is related to evaluation label Nov 4, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 4, 2025

Response from ADK Triaging Agent

Hello @nimanthadilz, thank you for creating this PR!

In order to get this PR merged, could you please:

  • Sign our Contributor License Agreement (CLA).
  • Add unit tests for your change.

This information will help reviewers to review your PR more efficiently. Thanks!

@nimanthadilz
Copy link
Contributor Author

Closing this PR since my email is not matching with CLA. I will recreate one with correct email.

@ryanaiagent ryanaiagent self-assigned this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval [Component] This issue is related to evaluation

3 participants