x/net/dns/dnsmessage: add https svcb dns types #241

fortuna · 2025-10-09T21:27:10Z

This change implements the proposal to add new DNS message types HTTPS and
SVCB in the golang.org/x/net/dns/dnsmessage package, as described in
golang/go#43790.

The implementation includes:

New types TypeHTTPS and TypeSVCB.
SVCBResource and HTTPSResource structs, with HTTPSResource embedding
SVCBResource.
SVCParam and SVCParamKey types for handling service parameters.
pack and unpack methods for the new resource types.
Integration into the Parser and Builder.
Comprehensive tests, including for parameter handling logic.

I implemented the SVCB parsing code so that it performs only two
allocations: one for the []SVCParam slice, and one to hold the SVCParam
values. A test was added to demonstrate that.

Fixes golang/go#43790

This change implements the proposal to add new DNS message types HTTPS and SVCB in the golang.org/x/net/dns/dnsmessage package, as described in golang/go#43790. The implementation includes: - New types `TypeHTTPS` and `TypeSVCB`. - `SVCBResource` and `HTTPSResource` structs, with `HTTPSResource` embedding `SVCBResource`. - `SVCParam` and `SVCParamKey` types for handling service parameters. - `pack` and `unpack` methods for the new resource types. - Integration into the `Parser` and `Builder`. - Comprehensive tests, including for parameter handling logic. Note: Two tests, `TestDNSPackUnpack` and `TestParsingAllocs`, are still failing. The `TestParsingAllocs` failure is considered acceptable as further optimization would require unsafe code. The `TestDNSPackUnpack` failure is due to a subtle issue with `reflect.DeepEqual` and slice capacities that I was unable to resolve.

Added comment for SVCParamKey values reference.

gopherbot · 2025-10-09T21:36:18Z

This PR (HEAD: 7cb10b8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-09T21:51:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-09T21:51:34Z

Message from Vinicius Fortuna:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-09T21:51:35Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T21:27:43Z

This PR (HEAD: 00e1850) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-13T02:47:31Z

This PR (HEAD: 274d339) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-13T03:16:18Z

Message from Vinicius Fortuna:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T03:16:18Z

Message from Vinicius Fortuna:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:40:30Z

Message from t hepudds:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:40:30Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-13T12:27:18Z","revision":"3e77cea34ac96420e73a05e6fa88907ba50039c4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:48:35Z

Message from t hepudds:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:48:36Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:48:36Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T12:56:42Z

Message from t hepudds:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T16:10:52Z

Message from Vinicius Fortuna:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T16:27:04Z

Message from Mateusz Poliwczak:

Patch Set 6:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T16:57:05Z

Message from Mateusz Poliwczak:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T16:57:05Z

Message from Mateusz Poliwczak:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T17:04:48Z

Message from Mateusz Poliwczak:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T17:04:48Z

Message from Mateusz Poliwczak:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T17:12:35Z

Message from Mateusz Poliwczak:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T17:20:03Z

This PR (HEAD: 18a863e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-13T17:43:44Z

Message from Sean Liao:

Patch Set 7:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T23:43:28Z

Message from Vinicius Fortuna:

Patch Set 8:

(12 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T23:43:33Z

This PR (HEAD: 6e3be98) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-14T00:18:44Z

Message from Damien Neil:

Patch Set 10: Commit-Queue+1

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T00:25:55Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-14T00:12:51Z","revision":"15cfcbacff94e58de83ba3c068bd9fb4572f2636"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T00:33:04Z

Message from Damien Neil:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T00:33:04Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T00:33:05Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T04:15:12Z

This PR (HEAD: c33610b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710736.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-14T04:23:22Z

Message from Vinicius Fortuna:

Patch Set 10:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710736.
After addressing review feedback, remember to publish your drafts!

google-labs-jules bot and others added 2 commits October 9, 2025 21:20

Document SVCParamKey with IANA reference

7cb10b8

Added comment for SVCParamKey values reference.

fortuna mentioned this pull request Oct 9, 2025

x/net/dns/dnsmessage: add support for SVCB and HTTPS records golang/go#43790

Open

fortuna changed the title ~~Add https svcb dns types~~ x/net/dns/dnsmessage: add https svcb dns types Oct 9, 2025

Fix TestDNSPackUnpack

00e1850

Fixes and improvement

274d339

fortuna marked this pull request as ready for review October 13, 2025 02:48

Add examples from RFC

18a863e

fortuna added 3 commits October 13, 2025 17:44

Use Go doc link

696d2a4

Address review comments

cc7608c

Finish tests

6e3be98

fortuna added 2 commits October 14, 2025 00:01

Address review comments

8774df3

Test SVCParam

c33610b

x/net/dns/dnsmessage: add https svcb dns types #241

Are you sure you want to change the base?

x/net/dns/dnsmessage: add https svcb dns types #241

Conversation

fortuna commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gopherbot commented Oct 9, 2025

gopherbot commented Oct 9, 2025

gopherbot commented Oct 9, 2025

gopherbot commented Oct 9, 2025

gopherbot commented Oct 12, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 13, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

gopherbot commented Oct 14, 2025

Labels

2 participants

fortuna commented Oct 9, 2025 •

edited

Loading