Skip to content

net/http2: pool transport gzip readers #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

net/http2: pool transport gzip readers #239

wants to merge 2 commits into from
+134 −14

Conversation

AlexanderYastrebov
Copy link
Contributor

@AlexanderYastrebov AlexanderYastrebov commented Oct 8, 2025 •
edited
Loading

This is a copy of the CL 510255 with the difference that
it preserves use of fs.ErrClosed when reading after close.

goos: darwin
goarch: arm64
pkg: golang.org/x/net/http2
cpu: Apple M4
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10)

 │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │

ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10)

 │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │

ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10)

Updates golang/go#61353
@gopherbot
Copy link
Contributor

This PR (HEAD: 5e48e81) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Alexander Yastrebov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-08T20:32:55Z","revision":"8e3e4d8fcffc1ff884c8c9290d9b1865375baa7b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@AlexanderYastrebov
http2: add transport gzip response benchmark
32b70f4 
For golang/go#61353
@AlexanderYastrebov
http2: pool transport gzip readers
4d04dc9 
This is a copy of the CL 510255 with the difference that it preserves use of fs.ErrClosed when reading after close. goos: darwin goarch: arm64 pkg: golang.org/x/net/http2 cpu: Apple M4 │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10) Updates golang/go#61353
@gopherbot
Copy link
Contributor

This PR (HEAD: 4d04dc9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-12T17:26:03Z","revision":"d9d2957a636f1d0545124b73575609a8f86bdbd4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@AlexanderYastrebov @gopherbot @kmk142789