Check for v prefix on tags for release clean name (#28257) #28270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GiteaBot added modifies/internal topic/build GiteaBot added the lgtm/need 2 
delvh approved these changes Nov 28, 2023
GiteaBot added lgtm/need 1 
jolheiser approved these changes Nov 28, 2023
GiteaBot added lgtm/done 
techknowlogick pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport #28257 by @jolheiser
As title, this will strip the
vprefix when getting a "clean" name for a tag.From the last run:
https://github.com/go-gitea/gitea/actions/runs/7015365494/job/19084572109
REF_NAME=$(echo "refs/tags/v1.20.6" | sed -e 's/refs\/heads\///' -e 's/refs\/tags\///' -e 's/release\/v//')It strips
ref/tags/and just needs to strip the additionalv.