boundos:insideBaseDirEval: return true if baseDir is "/" #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I'll fix these tests, they really should be updated to use errors.Is. need to see how to do that in the context of this test framework. |
pjbgf requested changes Apr 19, 2024
@rminnich Feel free to add a commit to that effect or do a follow-up PR. |
Merged
insideBaseDirEval would fail if baseDir was "/". Since "/" contains anything, and can never be a symlink, just return true, nil if baseDir is "/". Add a simple test for this case. Also, while we are at it, have the returned error be a lot more informative: show the name and the base diectory; further, have it wrap os.ErrNotExist should anyone wish to use errors.Is at some point. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
pjbgf approved these changes Apr 28, 2024
| Thank you @rminnich! 🙇 |
| Fixes #42 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
insideBaseDirEval would fail if baseDir was "/".
Since "/" contains anything, and can never be a symlink, just return true, nil if baseDir is "/".
Add a simple test for this case.
Also, while we are at it, have the returned error be a lot more informative: show the name and the base diectory; further, have it wrap os.ErrNotExist should anyone wish to use errors.Is at some point.