Memory.ReadDir() should return an error when path isn't found. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pjbgf reviewed Nov 16, 2023
pjbgf reviewed Nov 16, 2023
| Looks like the tests are failing due to a websocket timeout? I don't think that would be related to my changes--would it be possible to rerun the tests and see if it's a fluke? |
pjbgf reviewed Nov 17, 2023
@weberc2-tempus It was a fluke. I re-run it and it now passed. We only need to fix the windows issue. Please squash your commits. |
weberc2-tempus force-pushed the memfs-readdir-enoent branch from 26b152b to 28a448a Compare pjbgf reviewed Nov 20, 2023
Presently, it returns an empty list of files and a `nil` error value. This PR aims to fix go-git#37.
weberc2-tempus force-pushed the memfs-readdir-enoent branch from 28a448a to b22371c Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Presently, it returns an empty list of files and a
nilerror value. This PR aims to fix #37