Support opening branches popup from all tabs #2709
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kpbaks force-pushed the open-branches-from-all-tabs branch from 1153424 to 9407b4e Compare kpbaks changed the title 
| @kpbaks great idea! Why is it |
| Miss-click I think 😅 |
kpbaks force-pushed the open-branches-from-all-tabs branch from 9407b4e to 928e421 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This Pull Request makes it so pressing b opens the Branches popup in all 5 tabs, not only Status and Log tab. This keeps the behavior consistent, and makes the program simpler to use, since you do not have to associate being in a subset of the available tabs, in order to open a, what I would consider, global popup.
The b is not being used in any of the 3 missing tabs, so the change does not conflict with any existing keybinds.
If accepted, I think it would benefit the codebase to have a concept of global keybinds, that are accessible from all tabs, to deduplicate the repeated code to e.g. add a branches keybind.
I followed the checklist:
make checkwithout errors