Skip to content

Conversation

@khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 20, 2024

We recently decided to drop node 14 and 16 support..

I forgot to remove the node version from the publish workflow resulting in publish workflow failure, so this PR drops it and upgrades the version to node 18.

@khiga8 khiga8 requested a review from a team as a code owner May 20, 2024 17:37
@khiga8 khiga8 requested a review from dgreif May 20, 2024 17:37
@khiga8 khiga8 changed the title Drop node 14 in publish workflow Bump node 14 to node 18 in publish workflow May 20, 2024
@dgreif dgreif merged commit 2b8550f into main May 20, 2024
@dgreif dgreif deleted the kh-drop-14-support branch May 20, 2024 17:47
WtfJoke referenced this pull request in WtfJoke/setup-groovy Aug 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-github](https://togithub.com/github/eslint-plugin-github) | [`4.10.2` -> `5.0.1`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-github/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-github/4.10.2/5.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/eslint-plugin-github (eslint-plugin-github)</summary> ### [`v5.0.1`](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.1) [Compare Source](https://togithub.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1) #### What's Changed - chore(deps): bump the all-dependencies group with 5 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/530](https://togithub.com/github/eslint-plugin-github/pull/530) - Provide `no-redundant-roles` exception for `rowgroup` by [@&#8203;khiga8](https://togithub.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/531](https://togithub.com/github/eslint-plugin-github/pull/531) **Full Changelog**: github/eslint-plugin-github@v5.0.0...v5.0.1 ### [`v5.0.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.0) [Compare Source](https://togithub.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0) Formally releasing v5.0.0! This release includes everything in pre-release [v5.0.0-2](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)! We notably dropped support for node 14 and node 16 in favor of node 18. #### What's Changed - Drop node 14/16 support and fix bug in `getElementType` logic by [@&#8203;khiga8](https://togithub.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/525](https://togithub.com/github/eslint-plugin-github/pull/525) - Bump node 14 to node 18 by [@&#8203;khiga8](https://togithub.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/529](https://togithub.com/github/eslint-plugin-github/pull/529) - chore(deps): bump the all-dependencies group with 4 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/510](https://togithub.com/github/eslint-plugin-github/pull/510) - chore(deps): bump the all-dependencies group with 2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/511](https://togithub.com/github/eslint-plugin-github/pull/511) - chore(deps): bump the all-dependencies group with 2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/512](https://togithub.com/github/eslint-plugin-github/pull/512) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/514](https://togithub.com/github/eslint-plugin-github/pull/514) - chore(deps): bump the all-dependencies group across 1 directory with 4 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/522](https://togithub.com/github/eslint-plugin-github/pull/522) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/WtfJoke/setup-groovy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
WtfJoke referenced this pull request in WtfJoke/setup-tectonic Sep 13, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-github](https://redirect.github.com/github/eslint-plugin-github) | [`4.10.2` -> `5.0.2`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-github/5.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-github/5.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-github/4.10.2/5.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-github/4.10.2/5.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/eslint-plugin-github (eslint-plugin-github)</summary> ### [`v5.0.2`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.2) [Compare Source](https://redirect.github.com/github/eslint-plugin-github/compare/v5.0.1...v5.0.2) #### What's Changed - chore(deps): bump the all-dependencies group across 1 directory with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/533](https://redirect.github.com/github/eslint-plugin-github/pull/533) - chore(deps): bump braces from 3.0.2 to 3.0.3 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/534](https://redirect.github.com/github/eslint-plugin-github/pull/534) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/535](https://redirect.github.com/github/eslint-plugin-github/pull/535) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/536](https://redirect.github.com/github/eslint-plugin-github/pull/536) - chore(deps): bump the all-dependencies group with 4 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/537](https://redirect.github.com/github/eslint-plugin-github/pull/537) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/538](https://redirect.github.com/github/eslint-plugin-github/pull/538) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/540](https://redirect.github.com/github/eslint-plugin-github/pull/540) - chore(deps): bump the all-dependencies group with 4 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/541](https://redirect.github.com/github/eslint-plugin-github/pull/541) - chore(deps): bump the all-dependencies group across 1 directory with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/543](https://redirect.github.com/github/eslint-plugin-github/pull/543) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/544](https://redirect.github.com/github/eslint-plugin-github/pull/544) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/545](https://redirect.github.com/github/eslint-plugin-github/pull/545) - chore(deps): bump the all-dependencies group across 1 directory with 4 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/551](https://redirect.github.com/github/eslint-plugin-github/pull/551) **Full Changelog**: github/eslint-plugin-github@v5.0.1...v5.0.2 ### [`v5.0.1`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.1) [Compare Source](https://redirect.github.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1) #### What's Changed - chore(deps): bump the all-dependencies group with 5 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/530](https://redirect.github.com/github/eslint-plugin-github/pull/530) - Provide `no-redundant-roles` exception for `rowgroup` by [@&#8203;khiga8](https://redirect.github.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/531](https://redirect.github.com/github/eslint-plugin-github/pull/531) **Full Changelog**: github/eslint-plugin-github@v5.0.0...v5.0.1 ### [`v5.0.0`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.0) [Compare Source](https://redirect.github.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0) Formally releasing v5.0.0! This release includes everything in pre-release [v5.0.0-2](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)! We notably dropped support for node 14 and node 16 in favor of node 18. #### What's Changed - Drop node 14/16 support and fix bug in `getElementType` logic by [@&#8203;khiga8](https://redirect.github.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/525](https://redirect.github.com/github/eslint-plugin-github/pull/525) - Bump node 14 to node 18 by [@&#8203;khiga8](https://redirect.github.com/khiga8) in [https://github.com/github/eslint-plugin-github/pull/529](https://redirect.github.com/github/eslint-plugin-github/pull/529) - chore(deps): bump the all-dependencies group with 4 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/510](https://redirect.github.com/github/eslint-plugin-github/pull/510) - chore(deps): bump the all-dependencies group with 2 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/511](https://redirect.github.com/github/eslint-plugin-github/pull/511) - chore(deps): bump the all-dependencies group with 2 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/512](https://redirect.github.com/github/eslint-plugin-github/pull/512) - chore(deps): bump the all-dependencies group with 3 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/514](https://redirect.github.com/github/eslint-plugin-github/pull/514) - chore(deps): bump the all-dependencies group across 1 directory with 4 updates by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/github/eslint-plugin-github/pull/522](https://redirect.github.com/github/eslint-plugin-github/pull/522) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/WtfJoke/setup-tectonic). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants