fix: Strip query strings from asset paths #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
timfish commented Oct 6, 2025
timfish commented - Closes Hash as query in webpack #737
Lms24 approved these changes Oct 9, 2025
Member
Lms24 left a comment
Lms24 left a comment There was a problem hiding this comment.
Thanks! Sounds reasonable to me.
| await sentryBuildPluginManager.uploadSourcemaps(buildArtifactPaths); | ||
| // Webpack and perhaps other bundlers allow you to append query strings to | ||
| // filenames for cache busting purposes. We should strip these before upload. | ||
| const cleanedPaths = buildArtifactPaths.map((p) => p.split("?")[0] || p); |
Member
There was a problem hiding this comment.
l: we already have a stripQueryAndHashFromPath helper we can reuse here.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 11, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.3.0 | 4.4.0 | ## [v4.4.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#440) - feat(core): Explicitly allow `undefined` as value for `authToken` option ([#805](getsentry/sentry-javascript-bundler-plugins#805)) - fix(core): Strip query strings from asset paths ([#806](getsentry/sentry-javascript-bundler-plugins#806)) Work in this release was contributed by [@aiktb](https://github.com/aiktb). Thank you for your contribution!
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 11, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.3.0 | 4.4.0 | ## [v4.4.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#440) - feat(core): Explicitly allow `undefined` as value for `authToken` option ([#805](getsentry/sentry-javascript-bundler-plugins#805)) - fix(core): Strip query strings from asset paths ([#806](getsentry/sentry-javascript-bundler-plugins#806)) Work in this release was contributed by [@aiktb](https://github.com/aiktb). Thank you for your contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.