Formal PR for DevOps Task #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Initial test of GitHub actions
changed ti install, test
trying with cd command
attempt with npm ci and actions/setup-node@v3
attempt with "working-directory" parameters running: - npm run start - npm run test
fixed git fail
…conf file being copied inside the container
Changed dockerfile to give nginx user privileges and deleted user mode from nginx.conf
Changed location in the server parameters to /index.html
Modified .ignore files, since was building project locally for testing Modified compose for correct port forwarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Formal PR for my DevOps Task to see changes in the project