Handle app-compat environment check where self does not exist #8378
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Properly handle the case in app-compat checks where
windowexists butselfdoes not. (This apparently occurs in Ionic Stencil's Jest preset.)This is a safer check as
isBrowser()now checks for the existence ofwindow, so if it passes, the second condition shouldn't error.Fixes #8365