Skip to content

Snapshot listener source from cache #12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 11, 2024
Merged

Snapshot listener source from cache #12370

merged 20 commits into from
Mar 11, 2024

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Feb 7, 2024 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Apple API Diff Report

Commit: b7a243d
Last updated: Fri Mar 8 10:58 PST 2024
View workflow logs & download artifacts

[BUILD ERROR] FirebaseFirestore
@google-oss-bot
Copy link

google-oss-bot commented Feb 7, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.20% (48a77e3) to 88.13% (b7a243d) by -0.07%.

    13 individual files with coverage change

    FilenameBase (48a77e3)Merge (b7a243d)Diff
    converters.mm100.00%87.10%-12.90%
    event_manager.cc98.08%98.65%+0.57%
    exception.cc84.21%23.68%-60.53%
    FIRDocumentReference.mm97.10%97.20%+0.10%
    FIRQuery.mm87.87%88.00%+0.13%
    FIRSnapshotListenOptions.mm?100.00%?
    leveldb_key.cc98.14%99.02%+0.88%
    leveldb_persistence.cc93.59%92.31%-1.28%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    lru_garbage_collector.cc96.06%91.34%-4.72%
    status.cc75.89%73.05%-2.84%
    sync_engine.cc95.34%95.56%+0.22%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6zl2QHTRO7.html
@milaGGL milaGGL marked this pull request as ready for review February 15, 2024 19:40
@milaGGL milaGGL requested a review from wu-hui February 29, 2024 20:09
@milaGGL milaGGL requested a review from markarndt March 5, 2024 19:33
wu-hui
wu-hui approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!!
@wu-hui wu-hui assigned milaGGL and unassigned wu-hui Mar 5, 2024
markarndt
markarndt approved these changes Mar 5, 2024
View reviewed changes
@milaGGL milaGGL merged commit 07b7669 into main Mar 11, 2024
@milaGGL milaGGL deleted the mila/snapshot-listener-from-cache branch March 11, 2024 18:53
ncooke3 added a commit that referenced this pull request Mar 12, 2024
@ncooke3
[Firestore] Add unlinked symbol introduced in #12370
0329eda
ncooke3 added a commit that referenced this pull request Mar 12, 2024
@ncooke3
[Firestore] Add unlinked symbol introduced in #12370 (#12534)
f764572
ncooke3 added a commit that referenced this pull request Mar 12, 2024
@ncooke3
[Firestore] Re-export public header added in #12370
67e0e7b
ncooke3 added a commit that referenced this pull request Mar 12, 2024
@ncooke3
[Firestore] Re-export public header added in #12370 (#12537)
77920e3
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Apr 9, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
8cead7d 
….23.1" (#948) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk) | minor | `from: "10.21.0"` -> `from: "10.23.1"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v10.23.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.1) [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.0...10.23.1) The Firebase Apple SDK (10.23.1) is now available. This release is only available for CocoaPods and Swift Package Manager and only changes Firebase Analytics. See details at [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.23.1) #### What's Changed - \[Release] Update Package.swift for 10.23.1 patch by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12644](https://togithub.com/firebase/firebase-ios-sdk/pull/12644) - Analytics 10.23.1 by [@&#8203;htcgh](https://togithub.com/htcgh) in [https://github.com/firebase/firebase-ios-sdk/pull/12648](https://togithub.com/firebase/firebase-ios-sdk/pull/12648) - 10.23.1 podspec updates by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12647](https://togithub.com/firebase/firebase-ios-sdk/pull/12647) - Tweak release note by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12649](https://togithub.com/firebase/firebase-ios-sdk/pull/12649) **Full Changelog**: firebase/firebase-ios-sdk@10.23.0...10.23.1 ### [`v10.23.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.0) [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.1...10.23.0) The Firebase Apple SDK (10.23.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.23.0) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) #### What's Changed - \[Release] Update versions for Release 10.23.0 by [@&#8203;andrewheard](https://togithub.com/andrewheard) in [https://github.com/firebase/firebase-ios-sdk/pull/12467](https://togithub.com/firebase/firebase-ios-sdk/pull/12467) - Add API tests for hashed email and phone number by [@&#8203;tsunghung](https://togithub.com/tsunghung) in [https://github.com/firebase/firebase-ios-sdk/pull/12469](https://togithub.com/firebase/firebase-ios-sdk/pull/12469) - Update upload-symbols to 13.7 by [@&#8203;themiswang](https://togithub.com/themiswang) in [https://github.com/firebase/firebase-ios-sdk/pull/12471](https://togithub.com/firebase/firebase-ios-sdk/pull/12471) - Analytics 10.22.1 by [@&#8203;tsunghung](https://togithub.com/tsunghung) in [https://github.com/firebase/firebase-ios-sdk/pull/12482](https://togithub.com/firebase/firebase-ios-sdk/pull/12482) - Upgrade `clang-format` to v18 by [@&#8203;andrewheard](https://togithub.com/andrewheard) in [https://github.com/firebase/firebase-ios-sdk/pull/12483](https://togithub.com/firebase/firebase-ios-sdk/pull/12483) - \[Release] Add patch note for 10.22.1 by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12490](https://togithub.com/firebase/firebase-ios-sdk/pull/12490) - Restore 10.23.0 versions to main after 10.22.1 by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12497](https://togithub.com/firebase/firebase-ios-sdk/pull/12497) - Patch abseil-cpp to ignore deprecated errors in new Xcode. by [@&#8203;jonsimantov](https://togithub.com/jonsimantov) in [https://github.com/firebase/firebase-ios-sdk/pull/12498](https://togithub.com/firebase/firebase-ios-sdk/pull/12498) - Fix CI breakage from recent merge by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12504](https://togithub.com/firebase/firebase-ios-sdk/pull/12504) - Resolved warning no rule to process file 'PrivacyInfo.xcprivacy' of type 'text.xml' with CocoaPods by [@&#8203;HikaruSato](https://togithub.com/HikaruSato) in [https://github.com/firebase/firebase-ios-sdk/pull/12513](https://togithub.com/firebase/firebase-ios-sdk/pull/12513) - Upgrade grpc to 1.62 for cocoapods by [@&#8203;wu-hui](https://togithub.com/wu-hui) in [https://github.com/firebase/firebase-ios-sdk/pull/12398](https://togithub.com/firebase/firebase-ios-sdk/pull/12398) - Snapshot listener source from cache by [@&#8203;milaGGL](https://togithub.com/milaGGL) in [https://github.com/firebase/firebase-ios-sdk/pull/12370](https://togithub.com/firebase/firebase-ios-sdk/pull/12370) - \[Rollouts] Feature rollouts merge to main by [@&#8203;themiswang](https://togithub.com/themiswang) in [https://github.com/firebase/firebase-ios-sdk/pull/12410](https://togithub.com/firebase/firebase-ios-sdk/pull/12410) - \[spm] Update grpc to 1.62.3 by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12520](https://togithub.com/firebase/firebase-ios-sdk/pull/12520) - \[Release Tooling] Copy over macOS/macCatalyst plists by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12517](https://togithub.com/firebase/firebase-ios-sdk/pull/12517) - NOTICES Change by [@&#8203;github-actions](https://togithub.com/github-actions) in [https://github.com/firebase/firebase-ios-sdk/pull/12524](https://togithub.com/firebase/firebase-ios-sdk/pull/12524) - Changelog updates for 10.23.0 by [@&#8203;paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12533](https://togithub.com/firebase/firebase-ios-sdk/pull/12533) - \[Firestore] Improve logging in scripts/check_firestore_symbols.sh by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12535](https://togithub.com/firebase/firebase-ios-sdk/pull/12535) - \[Firestore] Add unlinked symbol introduced in [#&#8203;12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370) by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12534](https://togithub.com/firebase/firebase-ios-sdk/pull/12534) - \[Firestore] Re-export public header added in [#&#8203;12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370) by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12537](https://togithub.com/firebase/firebase-ios-sdk/pull/12537) - \[Firestore] Bump dependency ranges for Firestore's binary SPM distro by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12538](https://togithub.com/firebase/firebase-ios-sdk/pull/12538) - Fix Firestore build warnings by [@&#8203;cherylEnkidu](https://togithub.com/cherylEnkidu) in [https://github.com/firebase/firebase-ios-sdk/pull/12536](https://togithub.com/firebase/firebase-ios-sdk/pull/12536) - Analytics 10.23.0 by [@&#8203;htcgh](https://togithub.com/htcgh) in [https://github.com/firebase/firebase-ios-sdk/pull/12539](https://togithub.com/firebase/firebase-ios-sdk/pull/12539) - \[Release] Update FirebaseFirestoreInternal checksum by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12545](https://togithub.com/firebase/firebase-ios-sdk/pull/12545) - \[Release] Re-spin FST with signed artifact by [@&#8203;ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12549](https://togithub.com/firebase/firebase-ios-sdk/pull/12549) #### New Contributors - [@&#8203;HikaruSato](https://togithub.com/HikaruSato) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12513](https://togithub.com/firebase/firebase-ios-sdk/pull/12513) **Full Changelog**: firebase/firebase-ios-sdk@10.22.1...10.23.0 ### [`v10.22.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.1): Firebase Apple 10.22.1 [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.0...10.22.1) The Firebase Apple SDK (10.22.1) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.22.1) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) ### [`v10.22.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.0): Firebase Apple 10.22.0 [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.21.0...10.22.0) The Firebase Apple SDK (10.22.0) is now available. For more details, see the [Firebase Apple SDK release notes](https://firebase.google.com/support/release-notes/ios#10.22.0). To install this SDK, see [Add Firebase to your project](https://firebase.google.com/docs/ios/setup). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore public-api-change

4 participants

@milaGGL @google-oss-bot @markarndt @wu-hui