Fix deployInstruction: Alt+click link appends comma at end #6511
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbimochan requested review from Timer, amyrlam, bugzpodder, gaearon, ianschmitz, iansu, mrmckeb and petetnt as code owners 
| Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| Thanks! |
| @ianschmitz Hi. I just realized that the issue is at terminal of vs-code. You can try at your machine. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
At deploy instruction, the generate publicUrl link is appended with comma and while clicking the link browser opens it with comma at end in my machine. [Mac pro 2016| Chrome Version 71.0.3578.98]
For e.g:
To publish it at http://sbimochan.github.io, run:
This "http://sbimochan.github.io, " gets into browser.