Skip to content

Conversation

@tommasini
Copy link

@tommasini tommasini commented Sep 10, 2024

Bumping send to 0.19 to solve GHSA-m6fv-jmcg-4jfg

Solves: #175

@jayvdb
Copy link

jayvdb commented Sep 11, 2024

Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ 🚀

Copy link

@chrysloi chrysloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tommasini

@tommasini
Copy link
Author

@UlisesGascon It's unclear to me why node v8 and v9 unit tests are failing looking at the github CI. Taking a look and running it locally it seems that the 92 tests are passing! Do you have a hint of what's happening?

Copy link

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 8/9 was failing same target branch 1.x similarly couple yrs/days ago

so unrelated to our bump ^ looks good to merge

@wesleytodd wesleytodd force-pushed the chore/bump-send-dependency branch from 0731aca to a009e6c Compare September 11, 2024 17:08
@wesleytodd wesleytodd force-pushed the chore/bump-send-dependency branch from a009e6c to 1b59883 Compare September 11, 2024 17:11
@wesleytodd wesleytodd merged commit 4263f49 into expressjs:1.x Sep 11, 2024
@s100
Copy link

s100 commented Sep 12, 2024

This change went into serve-static@1.16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

8 participants