Remove unused depd dependency #6197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| This is used in version 4 to display the deprecation message in some functions, and I suppose it will be used again in version 5 when there are deprecated methods. |
Member
| Yeah, that was the use, but I think we just overlookoed removing the dep when we removed those warnings. We should just bring the dep back when/if we need it and not force folks to install it when it is not used. |
wesleytodd approved these changes Jan 11, 2025
bjohansebas approved these changes Jan 11, 2025
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove the
depd, which no longer appears to be used anywhere.