refactor: simplify normalizeTypes function #6097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Replaced the manual for loop with Array.map for better readability and conciseness. - The new implementation directly maps each element in the input array to the normalized output, improving code clarity. - This change maintains the same functionality while leveraging built-in array methods for cleaner code.
wesleytodd approved these changes Jan 15, 2025
Member
wesleytodd left a comment
wesleytodd left a comment There was a problem hiding this comment.
this is an alright change.
UlisesGascon approved these changes Feb 4, 2025
UlisesGascon changed the title normalizeTypes function 
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related: #6093