Skip to content

Conversation

inigomarquinez
Copy link
Member

@inigomarquinez inigomarquinez commented May 5, 2024

This PR fixes nyc version to 14.1.1 when running tests in node 8 or node 9. nyc 15.x requires a yargs package version that requires node >=10.

I've also added the latest versions of node (18, 19, 20, 21 and 22) to the matrix.

Related to jshttp/http-errors#108

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon merged commit f3e6f38 into expressjs:master May 14, 2024
@UlisesGascon
Copy link
Member

The CI worked as expected, see for more details.

@inigomarquinez inigomarquinez deleted the ci/fix-tests-in-node-8-and-9 branch May 16, 2024 06:38
@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants