remove unmaintained errors pkg(github.com/pkg/errors) #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
koba1t force-pushed the remove_unmaintained_error_pkg branch from 3ec657b to 106306d Compare 
cbandy approved these changes Nov 30, 2024
| if idx < 0 { | ||
| if !SupportNegativeIndices { | ||
| return errors.Wrapf(ErrInvalidIndex, "Unable to access invalid index: %d", idx) | ||
| return fmt.Errorf("Unable to access invalid index: %d : %w", idx, ErrInvalidIndex) |
There was a problem hiding this comment.
nitpick; this message is one space different from the one on L420.
Suggested change
| return fmt.Errorf("Unable to access invalid index: %d : %w", idx, ErrInvalidIndex) | |
| return fmt.Errorf("Unable to access invalid index: %d: %w", idx, ErrInvalidIndex) |
| This library is abandoned you have only to fork it |
| No it is not. |
| There is no reason to make this change, it simply churn versions for no reason. |
| I had a cup of coffee and changed my mind. |
| Thanks for your decision to accept this change! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix: #205