Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/util/get-allow-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports.schema = {
type: "array",
items: {
type: "string",
pattern: "^(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$",
pattern: "^(?:virtual:)?(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$",
},
uniqueItems: true,
}
10 changes: 10 additions & 0 deletions tests/lib/rules/no-extraneous-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,16 @@ ruleTester.run("no-extraneous-import", rule, {
filename: fixture("tsconfig-paths/index.ts"),
code: "import foo from '#configurations/foo'",
},

// virtual modules
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-name';",
},
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-scope/name';",
},
],
invalid: [
{
Expand Down
10 changes: 10 additions & 0 deletions tests/lib/rules/no-extraneous-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ tester.run("no-extraneous-require", rule, {
filename: fixture("dependencies/a.js"),
code: "require('ccc')",
},

// virtual modules
{
filename: fixture("test.js"),
code: "require('virtual:package-name');",
},
{
filename: fixture("test.js"),
code: "require('virtual:package-scope/name');",
},
],
invalid: [
{
Expand Down
23 changes: 23 additions & 0 deletions tests/lib/rules/no-missing-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,17 @@ ruleTester.run("no-missing-import", rule, {
code: "import electron from 'electron';",
options: [{ allowModules: ["electron"] }],
},
// allow virtual modules
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-name';",
options: [{ allowModules: ["virtual:package-name"] }],
},
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-scope/name';",
options: [{ allowModules: ["virtual:package-scope"] }],
},

// resolvePaths
{
Expand Down Expand Up @@ -480,5 +491,17 @@ ruleTester.run("no-missing-import", rule, {
},
]
: []),

// virtual modules
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-name';",
errors: cantResolve("virtual:package-name"),
},
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-scope/name';",
errors: cantResolve("virtual:package-scope/name"),
},
],
})
23 changes: 23 additions & 0 deletions tests/lib/rules/no-missing-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,17 @@ ruleTester.run("no-missing-require", rule, {
code: "require('jquery.cookie');",
options: [{ allowModules: ["jquery.cookie"] }],
},
// allow virtual modules
{
filename: fixture("test.js"),
code: "require('virtual:package-name');",
options: [{ allowModules: ["virtual:package-name"] }],
},
{
filename: fixture("test.js"),
code: "require('virtual:package-scope/name');",
options: [{ allowModules: ["virtual:package-scope"] }],
},

// typescriptExtensionMap
{
Expand Down Expand Up @@ -440,6 +451,18 @@ ruleTester.run("no-missing-require", rule, {
code: "require.resolve('no-exist-package-0');",
errors: cantResolve("no-exist-package-0"),
},

// Virtual modules
{
filename: fixture("test.js"),
code: "require('virtual:package-name');",
errors: cantResolve("virtual:package-name"),
},
{
filename: fixture("test.js"),
code: "require('virtual:package-scope/name');",
errors: cantResolve("virtual:package-scope/name"),
},
],
})

Expand Down
12 changes: 12 additions & 0 deletions tests/lib/rules/no-unpublished-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,23 @@ ruleTester.run("no-unpublished-import", rule, {
code: "import a from './a';",
},

// allow module
{
filename: fixture("1/test.js"),
code: "import electron from 'electron';",
options: [{ allowModules: ["electron"] }],
},
// allow virtual modules
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-name';",
options: [{ allowModules: ["virtual:package-name"] }],
},
{
filename: fixture("test.js"),
code: "import a from 'virtual:package-scope/name';",
options: [{ allowModules: ["virtual:package-scope"] }],
},

// Auto-published files only apply to root package directory
{
Expand Down
11 changes: 11 additions & 0 deletions tests/lib/rules/no-unpublished-require.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,17 @@ ruleTester.run("no-unpublished-require", rule, {
code: "require('electron');",
options: [{ allowModules: ["electron"] }],
},
// allow virtual modules
{
filename: fixture("test.js"),
code: "require('virtual:package-name');",
options: [{ allowModules: ["virtual:package-name"] }],
},
{
filename: fixture("test.js"),
code: "require('virtual:package-scope/name');",
options: [{ allowModules: ["virtual:package-scope"] }],
},

// Auto-published files only apply to root package directory
{
Expand Down