Fix bug in citar-citeproc-select-csl-style #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benthamite changed the title citar-citeproc-select-csl-style Contributor Author
| Separately (as I just noticed), I think the prompt on line 87 should be "Select CSL style: ", since the user is prompted to select a style, not a file. |
Contributor
Could you please make that change while you're at it? |
Contributor Author
| Yep, done. |
Contributor
| Thanks! I did squash the commits so I could easily rewrite the commit message (though I realize there's a remaining mistake; the correction is to the prompt, rather than the docstring) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since
listis a list of cons cells, to get the name of the csl style whenlisthas one elementcaarneeds to be used;carreturns the cons cell itself.