Combine ignored fields spec with source paths #136771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With the recent addition of StoredFieldsSpec.sourcePaths, it is redundant to have a separate property for ignored source spec. This PR removes IgnoredSourceSpec and uses StoredFieldsSpec.sourcePaths instead.
elasticsearchmachine added needs:triage 
jordan-powers added >non-issue :Analytics/Aggregations 
| Pinging @elastic/es-storage-engine (Team:StorageEngine) |
…lds-spec-with-source-paths
…lds-spec-with-source-paths
martijnvg approved these changes Oct 20, 2025
| } else if (other.ignoredSourceFormat == IgnoredSourceFormat.NO_IGNORED_SOURCE) { | ||
| mergedFormat = this.ignoredSourceFormat; | ||
| } else if (this.ignoredSourceFormat != other.ignoredSourceFormat) { | ||
| throw new ElasticsearchException( |
There was a problem hiding this comment.
Should this be a IllegalStateException?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With the recent addition of StoredFieldsSpec.sourcePaths, it is redundant to have a separate property for ignored source spec.
This PR removes IgnoredSourceSpec and uses StoredFieldsSpec.sourcePaths instead.