Bookmark import flow observability (#7007)

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211724585727142?focus=true ### Description Adds observability around bookmark import flow and pre-import dialog. ### Steps to test this PR Logcat filter: `package:mine message~:"Bookmark-import: |Pixel sent: bookmark_import_from_google"` #### Import flow (success) - [x] Fresh install, and visit `Saved Site Dev Settings` - [x] Tap on `Launch Google Takeout import flow` - [x] Verify you see `bookmark_import_from_google_flow_started` in the logs, params should match spec - [x] Successfully import, and verify you see `bookmark_import_from_google_flow_success`, params should match spec (e.g., correct duration buckets) #### Import flow (cancellation) - [x] Start the import again, and this time cancel. - [x] Verify you see `bookmark_import_from_google_flow_cancelled` in the logs and it includes the `stepReached` alongside durations. #### Import flow (simulate error) - [x] Apply patch from below - [x] Start the import flow, and wait 2 seconds - [x] Verify you see `bookmark_import_from_google_flow_error` and `errorReason` starts with `webView-` then has the step. (e.g., `webView-takeout-first`) #### Pre-import dialogs <img width="20%" height="283" alt="Screenshot 2025-10-28 at 13 07 14" src="https://github.com/user-attachments/assets/132acbe5-b189-4bea-a9eb-ed9d6e73df82" /> - [x] Visit Bookmarks activity, and tap on `Import` (from empty state or overflow; doesn't matter) - [x] Verify `bookmark_import_from_google_dialog_shown` appears - [x] Tap the ✖️ to cancel the dialog; verify `bookmark_import_from_google_dialog_dismissed` appears - [x] Tap to show it again, and this time use the back button to dismiss; verifying same log appears - [x] Tap to show it again, and this time tap outside of the dialog to dismiss; verifying same log appears - [x] Tap to show it again, and this time choose `Select Bookmarks File`; verify `bookmark_import_from_google_dialog_fromfile` appeas - [x] Finally, choose `Import From Google` button and verify `bookmark_import_from_google_dialog_startflow` ### Patch to force a crash during import ``` Index: autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt --- a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt	(revision Staged) +++ b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt	(date 1761651295473) @@ -76,6 +76,7 @@ import com.duckduckgo.common.utils.plugins.PluginPoint import com.duckduckgo.di.scopes.FragmentScope import com.duckduckgo.user.agent.api.UserAgentProvider +import kotlinx.coroutines.delay import kotlinx.coroutines.flow.launchIn import kotlinx.coroutines.flow.onEach import kotlinx.coroutines.launch @@ -163,6 +164,13 @@ viewModel.firstPageLoading() } } + + // force a deliberate crash to test + lifecycleScope.launch { + delay(2000) + binding?.webView?.loadUrl("chrome://crash") + } + } private fun observeViewState() { ```

Author: CDRussell

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/ImportFromGoogleImpl.kt

@@ -42,7 +42,8 @@ class ImportFromGoogleImpl @Inject constructor(
  override suspend fun getBookmarksImportLaunchIntent(): Intent? {
  return withContext(dispatchers.io()) {
  if (autofillFeature.canImportBookmarksFromGoogleTakeout().isEnabled()) {
- globalActivityStarter.startIntent(context, ImportBookmarksViaGoogleTakeoutScreen)
+ val launchSource = getLaunchSource()
+ globalActivityStarter.startIntent(context, ImportBookmarksViaGoogleTakeoutScreen(launchSource))
  } else {
  null
  }
@@ -69,4 +70,9 @@ class ImportFromGoogleImpl @Inject constructor(
  }
  }
  }
+
+ private fun getLaunchSource(): String {
+ // launchSource can only be bookmarks screen or dev settings currently, so hardcoding to bookmarks screen for now
+ return "bookmarks_screen"
+ }
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarkResult.kt

@@ -49,5 +49,5 @@ sealed interface UserCannotImportReason : Parcelable {
  data object Unknown : UserCannotImportReason
 
  @Parcelize
- data object WebViewError : UserCannotImportReason
+ data class WebViewError(val step: String) : UserCannotImportReason
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt

@@ -27,28 +27,32 @@ import com.duckduckgo.appbuildconfig.api.AppBuildConfig
 import com.duckduckgo.autofill.impl.R
 import com.duckduckgo.autofill.impl.databinding.ActivityImportGoogleBookmarksWebflowBinding
 import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.Unknown
+import com.duckduckgo.autofill.impl.importing.takeout.webflow.journey.ImportGoogleBookmarksJourney
 import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.common.ui.viewbinding.viewBinding
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.navigation.api.GlobalActivityStarter
+import com.duckduckgo.navigation.api.getActivityParams
 import logcat.logcat
 import javax.inject.Inject
 
 /**
  * Launch the Google Bookmarks import flow
  */
-data object ImportBookmarksViaGoogleTakeoutScreen : GlobalActivityStarter.ActivityParams {
- private fun readResolve(): Any = ImportBookmarksViaGoogleTakeoutScreen
-}
+data class ImportBookmarksViaGoogleTakeoutScreen(val launchSource: String) : GlobalActivityStarter.ActivityParams
 
 @InjectWith(ActivityScope::class)
 @ContributeToActivityStarter(ImportBookmarksViaGoogleTakeoutScreen::class)
 class ImportGoogleBookmarksWebFlowActivity :
  DuckDuckGoActivity(),
  ImportGoogleBookmarksWebFlowFragment.WebViewVisibilityListener {
+
  @Inject
  lateinit var appBuildConfig: AppBuildConfig
 
+ @Inject
+ lateinit var importJourney: ImportGoogleBookmarksJourney
+
  val binding: ActivityImportGoogleBookmarksWebflowBinding by viewBinding()
 
  private var isOverlayCurrentlyShown = false
@@ -60,14 +64,16 @@ class ImportGoogleBookmarksWebFlowActivity :
  configureToolbar()
  configureResultListeners()
  launchWebFlow()
+ if (savedInstanceState == null) {
+ importJourney.started(getLaunchSource())
+ }
  }
 
  private fun launchWebFlow() {
  logcat { "Bookmark-import: Starting webflow" }
  isOnResultScreen = false
  replaceFragment(ImportGoogleBookmarksWebFlowFragment())
  updateToolbarTitle()
- invalidateOptionsMenu()
  }
 
  private fun showSuccessFragment(bookmarkCount: Int) {
@@ -82,7 +88,6 @@ class ImportGoogleBookmarksWebFlowActivity :
  isOverlayCurrentlyShown = false
  isOnResultScreen = true
  updateToolbarTitle()
- invalidateOptionsMenu()
  }
 
  private fun showErrorFragment(errorReason: UserCannotImportReason) {
@@ -99,7 +104,6 @@ class ImportGoogleBookmarksWebFlowActivity :
  isOverlayCurrentlyShown = false
  isOnResultScreen = true
  updateToolbarTitle()
- invalidateOptionsMenu()
  }
 
  private fun replaceFragment(fragment: Fragment) {
@@ -149,16 +153,19 @@ class ImportGoogleBookmarksWebFlowActivity :
  when (result) {
  is ImportGoogleBookmarkResult.Success -> {
  logcat { "Bookmark-import: ${javaClass.simpleName}, WebFlow succeeded with ${result.importedCount} bookmarks" }
+ importJourney.finishedWithSuccess()
  showSuccessFragment(result.importedCount)
  }
 
  is ImportGoogleBookmarkResult.UserCancelled -> {
  logcat { "Bookmark-import: ${javaClass.simpleName}, User cancelled at ${result.stage}" }
+ importJourney.cancelled(result.stage)
  exitUserCancelled(result.stage)
  }
 
  is ImportGoogleBookmarkResult.Error -> {
  logcat { "Bookmark-import: ${javaClass.simpleName}, Import failed with reason: ${result.reason}" }
+ importJourney.finishedWithError(error = result.reason)
  showErrorFragment(result.reason)
  }
 
@@ -223,14 +230,21 @@ class ImportGoogleBookmarksWebFlowActivity :
  }
 
  override fun showLoadingState() {
+ importJourney.startedWaitingForExport()
  showProgressOverlay()
  }
 
  override fun hideLoadingState() {
+ importJourney.stoppedWaitingForExport()
  hideProgressOverlay()
  }
 
+ private fun getLaunchSource(): String {
+ return intent.getActivityParams(ImportBookmarksViaGoogleTakeoutScreen::class.java)?.launchSource ?: UNKNOWN_LAUNCH_SOURCE
+ }
+
  companion object {
  private const val PROGRESS_OVERLAY_TAG = "progress_overlay"
+ private const val UNKNOWN_LAUNCH_SOURCE = "unknown"
  }
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt

@@ -63,11 +63,6 @@ import com.duckduckgo.autofill.impl.importing.takeout.webflow.ImportGoogleBookma
 import com.duckduckgo.autofill.impl.importing.takeout.webflow.ImportGoogleBookmarksWebFlowViewModel.ViewState.ShowWebPage
 import com.duckduckgo.autofill.impl.importing.takeout.webflow.ImportGoogleBookmarksWebFlowViewModel.ViewState.UserCancelledImportFlow
 import com.duckduckgo.autofill.impl.importing.takeout.webflow.ImportGoogleBookmarksWebFlowViewModel.ViewState.UserFinishedCannotImport
-import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.DownloadError
-import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.ErrorParsingBookmarks
-import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.Unknown
-import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.WebAutomationError
-import com.duckduckgo.autofill.impl.importing.takeout.webflow.UserCannotImportReason.WebViewError
 import com.duckduckgo.autofill.impl.jsbridge.request.SupportedAutofillInputSubType
 import com.duckduckgo.autofill.impl.jsbridge.request.SupportedAutofillInputSubType.PASSWORD
 import com.duckduckgo.autofill.impl.store.ReAuthenticationDetails
@@ -388,7 +383,7 @@ class ImportGoogleBookmarksWebFlowFragment :
 
  override fun onFatalWebViewError() {
  logcat(WARN) { "Bookmark-import: Fatal WebView error received" }
- exitFlowAsError(WebViewError)
+ viewModel.onFatalWebViewError()
  }
 
  private fun configureBackButtonHandler() {
@@ -435,7 +430,7 @@ class ImportGoogleBookmarksWebFlowFragment :
  }
 
  private fun exitFlowAsError(reason: UserCannotImportReason) {
- logcat { "Bookmark-import: Flow error at stage: ${reason.mapToStage()}" }
+ logcat { "Bookmark-import: Flow error at stage: $reason" }
  onWebFlowEnding()
 
  lifecycleScope.launch {
@@ -576,12 +571,3 @@ class ImportGoogleBookmarksWebFlowFragment :
  private const val SELECT_CREDENTIALS_FRAGMENT_TAG = "autofillSelectCredentialsDialog"
  }
 }
-
-private fun UserCannotImportReason.mapToStage(): String =
- when (this) {
- is DownloadError -> "zip-download-error"
- is ErrorParsingBookmarks -> "zip-parse-error"
- is Unknown -> "import-error-unknown"
- is WebViewError -> "webview-error"
- is WebAutomationError -> "web-automation-step-failure-${this.step}"
- }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModel.kt

@@ -260,6 +260,13 @@ class ImportGoogleBookmarksWebFlowViewModel @Inject constructor(
  }
  }
 
+ fun onFatalWebViewError() {
+ viewModelScope.launch {
+ val stage = webFlowStepObserver.getCurrentStep()
+ _commands.emit(ExitFlowAsFailure(UserCannotImportReason.WebViewError(stage)))
+ }
+ }
+
  companion object {
  private const val TAKEOUT_ADDRESS = "takeout.google.com"
  private const val ACCOUNTS_ADDRESS = "accounts.google.com"

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/journey/ImportGoogleBookmarksDurationBucketing.kt

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.autofill.impl.importing.takeout.webflow.journey
+
+import com.duckduckgo.di.scopes.AppScope
+import com.squareup.anvil.annotations.ContributesBinding
+import java.util.concurrent.TimeUnit
+import javax.inject.Inject
+
+interface ImportGoogleBookmarksDurationBucketing {
+ fun bucket(durationMillis: Long): String
+}
+
+@ContributesBinding(AppScope::class)
+class RealImportGoogleBookmarksDurationBucketing @Inject constructor() : ImportGoogleBookmarksDurationBucketing {
+
+ override fun bucket(durationMillis: Long): String {
+ if (durationMillis < 0) return "negative"
+ val seconds = TimeUnit.MILLISECONDS.toSeconds(durationMillis)
+
+ return when (seconds) {
+ in 0..19 -> "20"
+ in 20..39 -> "40"
+ in 40..59 -> "60"
+ in 60..89 -> "90"
+ in 90..119 -> "120"
+ in 120..149 -> "150"
+ in 150..179 -> "180"
+ in 180..239 -> "240"
+ in 240..299 -> "300"
+ else -> "longer"
+ }
+ }
+}