Skip to content

Conversation

@petertrr
Copy link
Contributor

@petertrr petertrr commented Jan 15, 2024

Closes #861

@petertrr petertrr marked this pull request as ready for review January 15, 2024 22:17
Copy link
Member

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR! Can you add Maven support as well?

@petertrr
Copy link
Contributor Author

Can you add Maven support as well?

Thanks for the suggestion! Added in the last commit.

# Conflicts: #	CHANGES.md #	plugin-maven/CHANGES.md #	plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java
CHANGES.md Outdated
## [Unreleased]
### Added
* Maven - Support for formatting shell scripts via [shfmt](https://github.com/mvdan/sh). ([#1998](https://github.com/diffplug/spotless/pull/1998))
* Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/issues/2001))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/issues/2001))
* Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/pull/2001))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just forgot to rename this to pull.

@@ -1,5 +1,5 @@
/*
* Copyright 2016-2023 DiffPlug
* Copyright 2016-2024 DiffPlug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change for now.

@Goooler Goooler requested a review from nedtwigg January 18, 2024 15:22
@nedtwigg nedtwigg enabled auto-merge January 22, 2024 08:06
@nedtwigg
Copy link
Member

Thanks for a great PR!

@nedtwigg nedtwigg merged commit 706f18e into diffplug:main Jan 22, 2024
@petertrr petertrr deleted the petertrr/add-gofmt#861 branch January 22, 2024 18:57
@nedtwigg
Copy link
Member

Shipped in plugin-gradle 6.25.0 and plugin-maven 2.43.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants