Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

sar009
Copy link
Contributor

@sar009 sar009 commented Jan 3, 2024

use

pip install data-diff 'data-diff[with_everything]' -U 

to install all database adapters

@sar009
Copy link
Contributor Author

sar009 commented Jan 3, 2024

fixes #833

Copy link
Contributor

@sungchun12 sungchun12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions. Overall, looks good!

pyproject.toml Outdated
clickhouse = ["clickhouse-driver"]
vertica = ["vertica-python"]
duckdb = ["duckdb"]
all-dbs = [
Copy link
Contributor

@sungchun12 sungchun12 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to this line? This makes it clear why this isn't part of the all-dbs extra list.

mssql = ["pyodbc"] # natively supported in Datafold Cloud only 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants