Allow a wordpress api request to specify certain status codes it want… #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| If you approve this modification, I'll update the readme if you like, as part of this. |
…s to allow/handle in response.
Codecov Report
@@ Coverage Diff @@ ## master #12 +/- ## ========================================== + Coverage 85.96% 85.97% +0.01% ========================================== Files 5 5 Lines 755 756 +1 ========================================== + Hits 649 650 +1 Misses 106 106
Continue to review full report at Codecov.
|
| Hey there, thanks for the PR, especially since it includes tests! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…s to allow/handle in response.
There are many cases where I might decide eg a 400 response is helpful - I have an import script for which it's more convenient to try and post something, and handle a 400 - telling me the item is already there, from a previous run of the script... rather than querying if it's there then posting only if it's not (which may be on average a slower process especially on the first run.)