⚡️ Speed up method MetadataToBoolInvocation.invoke by 15%

[codeflash-ai]

📄 15% (0.15x) speedup for MetadataToBoolInvocation.invoke in invokeai/app/invocations/metadata_linked.py

⏱️ Runtime : 11.3 microseconds → 9.77 microseconds (best of 36 runs)

📝 Explanation and details

The optimization achieves a 15% speedup by eliminating redundant attribute lookups and consolidating conditional logic into cleaner local variable assignments.

Key optimizations applied:

1. Reduced attribute lookups: The original code accessed self.metadata, self.label, and self.default_value multiple times. The optimized version stores these in local variables (metadata, label, default_value) to avoid repeated attribute access overhead.

2. Eliminated complex ternary expression: The original single-line ternary str(self.custom_label if self.label == CUSTOM_LABEL else self.label) was replaced with explicit if/else logic that pre-computes the lookup_key, reducing string conversion calls and making the logic more efficient.

3. Moved constant definition: CUSTOM_LABEL is now defined locally in the module rather than requiring a global lookup, making the comparison label == CUSTOM_LABEL faster.

4. Cleaner data dictionary creation: The metadata handling is now explicit with separate if/else branches rather than a ternary expression, which is more readable and slightly faster.

Why this leads to speedup: In Python, attribute lookups (self.attribute) are more expensive than local variable access. The line profiler shows the original complex expression took 17.1% of total time (3738ns), while the optimized version splits this into multiple cheaper operations. Local variables are stored in a fast array and accessed by index, while attributes require dictionary lookups.

Test case performance: The annotated tests show consistent 14-16% improvements across edge cases, particularly benefiting scenarios where metadata is None (a common case that now has a cleaner fast-path).

This optimization is especially valuable for metadata processing workflows where this function may be called repeatedly, as the per-invocation savings compound over many calls.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 6 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests and Runtime

from typing import Any, Dict, Optional # imports import pytest from invokeai.app.invocations.metadata_linked import MetadataToBoolInvocation # Simulate BooleanOutput for testing purposes class BooleanOutput: def __init__(self, value: bool): self.value = value # Simulate InvocationContext for testing purposes class InvocationContext: pass # Simulate WithMetadata for testing purposes class WithMetadata: def __init__(self, metadata=None): self.metadata = metadata # Simulate metadata.root for testing purposes class Metadata: def __init__(self, root: Dict[str, Any]): self.root = root # Constants CUSTOM_LABEL: str = "* CUSTOM LABEL *" # Helper function to mimic pydantic model_validator def validate_custom_label(self): # If label is CUSTOM_LABEL, custom_label must be set and not empty if getattr(self, 'label', None) == CUSTOM_LABEL: if not getattr(self, 'custom_label', None): raise ValueError("custom_label must be provided when label is CUSTOM_LABEL") return self from invokeai.app.invocations.metadata_linked import MetadataToBoolInvocation # --------------------- UNIT TESTS --------------------- # Basic Test Cases def test_edge_metadata_none(): # Test when metadata is None, should use default_value node = MetadataToBoolInvocation(label='seamless_x', default_value=True, metadata=None) codeflash_output = node.invoke(InvocationContext()); result = codeflash_output # 5.65μs -> 4.86μs (16.2% faster) def test_edge_custom_label_not_provided_raises(): # Test when label is CUSTOM_LABEL and custom_label is not provided, should raise ValueError with pytest.raises(ValueError): MetadataToBoolInvocation(label=CUSTOM_LABEL, custom_label=None, default_value=True, metadata=None) def test_edge_custom_label_empty_string_raises(): # Test when label is CUSTOM_LABEL and custom_label is empty string, should raise ValueError with pytest.raises(ValueError): MetadataToBoolInvocation(label=CUSTOM_LABEL, custom_label='', default_value=True, metadata=None) #------------------------------------------------ from dataclasses import dataclass # function to test from typing import Any, Dict, Optional # imports import pytest # used for our unit tests from invokeai.app.invocations.metadata_linked import MetadataToBoolInvocation # Mocks for dependencies (minimal, since we can't import actual classes) class BooleanOutput: def __init__(self, value: bool): self.value = value class InvocationContext: pass # Minimal metadata structure to simulate .root access @dataclass class Metadata: root: Dict[str, Any] # The function under test, adapted for testing CUSTOM_LABEL: str = "* CUSTOM LABEL *" from invokeai.app.invocations.metadata_linked import MetadataToBoolInvocation # unit tests # ----------- BASIC TEST CASES ----------- def test_edge_metadata_is_none(): """Test: metadata is None, should use default_value""" inv = MetadataToBoolInvocation(label="seamless_x", default_value=True, metadata=None) codeflash_output = inv.invoke(InvocationContext()); result = codeflash_output # 5.62μs -> 4.91μs (14.3% faster)

To edit these changes git checkout codeflash/optimize-MetadataToBoolInvocation.invoke-mhlkij2t and push.