Replace BodyBufferInputStream with MemoryInputStream #5461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a second attempt since we had to revert the first one
jasnell commented Nov 4, 2025
| // An optimized pumpTo... we know we have all the data right here. We can | ||
| // just write it all at once up to `amount`. | ||
| uint64_t toRead = kj::min(data.size(), amount); | ||
| KJ_DEFER(advance(toRead)); |
Collaborator Author
There was a problem hiding this comment.
Note for @harrishancock: I think this is actually the bit that caused the problem we saw in prod. The advance call would drop the ownedBacking once all the data was read. I think, however, that it was being dropped at the wrong time. The original BodyBufferInputStream did not drop the backing until the stream was destroyed. I've been unable to reproduce the specific failure we saw tho.
Collaborator
There was a problem hiding this comment.
That does sound likely. Essentially we were inadvertently dropping a V8 object outside of the isolate lock?
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a second attempt since we had to revert the first one.
This is not yet ready to land. It needs a test but I've been unable to reproduce the failure we saw in production with the original version.