Fix number-recorded type hint #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The type hint for for function returns should go between the var name and arguments. In the case of num-recorded, if you tried to do arithmetic on the returned value, you'd get an Exception like: `java.lang.IllegalArgumentException: Unable to resolve classname: clojure.core$long@6df773ef` See https://dev.clojure.org/jira/browse/CLJ-1753 and https://dev.clojure.org/jira/browse/CLJ-1674 for details.
michaelklishin approved these changes Feb 12, 2018
| Thank you! Sounds like it should be backported to 2.x (master is already 3.0). I'll take care of it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The type hint for for function returns should go between the var name
and arguments. In the case of num-recorded, if you tried to do
arithmetic on the returned value, you'd get an Exception like:
java.lang.IllegalArgumentException: Unable to resolve classname: clojure.core$long@6df773efSee https://dev.clojure.org/jira/browse/CLJ-1753 and
https://dev.clojure.org/jira/browse/CLJ-1674 for details.