Include 50th percentile in histogram and timer #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This seems to be a breaking API change. Do you know where in Metrics source can I find a confirmation that that's indeed the format expected by the core reporters? |
| I noticed the difference by comparing it to output of the the JmxReporter for Histogram and Timer. Other examples: ConsoleReporter (Histogram, Timer) or CsvReporter (Histogram, Timer). |
michaelklishin approved these changes Jan 31, 2018
| I'll bump the version to 3.0, not that this is a major API change but using 2.x forever is also not a goal. Thank you. |
michaelklishin added a commit that referenced this pull request Feb 3, 2018
michaelklishin added a commit that referenced this pull request Feb 3, 2018
But mostly because we can't go on with 2.x forever. The change in #129 is hardly major, so this is mostly a vanity bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Align the range of reported percentile values (JSON report from the Ring middleware) to the values returned by the core reporters e.g. JMX or Console.