Prevent toggling between min and max scroll offsets at end of grid #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bvaughn reviewed Jun 14, 2019
| if (scrollLeft >= minOffset && scrollLeft <= maxOffset) { | ||
| return scrollLeft; | ||
| } else if (minOffset > maxOffset) { | ||
| return minOffset; |
Owner
There was a problem hiding this comment.
I think this needs an explanatory comment, because it looks like a bug at first glance 😄
Contributor Author
There was a problem hiding this comment.
Fair point! Now added.
Owner
There was a problem hiding this comment.
Looks like you added other places but missed this one 😆
bvaughn approved these changes Jun 18, 2019
| if (scrollLeft >= minOffset && scrollLeft <= maxOffset) { | ||
| return scrollLeft; | ||
| } else if (minOffset > maxOffset) { | ||
| return minOffset; |
Owner
There was a problem hiding this comment.
Looks like you added other places but missed this one 😆
Owner
| Published in 1.8.3 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #257
Prevents toggling between the calculated minOffset and maxOffset when minOffset is greater than maxOffset owing to the scrollbar size.