Fix replace list with deque #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
phi-friday force-pushed the fix-replace-list-with-deque branch from 3f79fd4 to 23f4147 Compare 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #508 +/- ## ========================================== - Coverage 96.19% 96.12% -0.08% ========================================== Files 10 10 Lines 867 851 -16 ========================================== - Hits 834 818 -16 Misses 33 33 ☔ View full report in Codecov by Sentry. |
till-m approved these changes Sep 8, 2024
Member
till-m left a comment
till-m left a comment There was a problem hiding this comment.
Seems like a good thing to use a built-in for this instead of writing it ourselves!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace
queueimplemented usinglistwithdeque.The implementation with
listappears to be due to the use ofappend()and #370 .If
append()is used,dequeis more efficient, and #370 is also solved.