Partially fix #412 by adding a dedicated method to evaluating y_max

[leandrobbraga]

Partially Fixes #412.

The idea is to have a dedicated space property that calculates eagerly the y_max of the space, considering the constraints.

I decided to split the MR in two to ease the review. I'll be sending another MR soon with the fix of the warmup phase of the acq_max.

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (33b99ec) 98.57% compared to head (4215502) 98.58%.

❗ Current head 4215502 differs from pull request most recent head 99da524. Consider uploading reports for the commit 99da524 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@ ## master #415 +/- ## ========================================== + Coverage 98.57% 98.58% +0.01%  ========================================== Files 8 8 Lines 560 567 +7 Branches 79 83 +4 ========================================== + Hits 552 559 +7  Misses 4 4 Partials 4 4 

Impacted Files	Coverage Δ
bayes_opt/bayesian_optimization.py	100.00% <ø> (ø)
bayes_opt/target_space.py	99.23% <100.00%> (+0.04%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[till-m]

Looks good to me in general. Small note, as far as I know we're generally using target instead of y for the result of the function we are maximizing. I know that this is not consistent everywhere, but I think it would be good to go that direction here.

[leandrobbraga]

I had to adapt the tests after the last change, some were failing

[till-m]

LGTM -- will merge tomorrow!

[till-m]

Thanks for your contribution!