Skip to content

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 8, 2025

Description of changes:

Adds functions cmac::sign_to_buffer and cmac::Context::verify:

  • cmac::sign_to_buffer allows the caller to provide their own buffer into which the tag will be written.
  • cmac::Context::verify allows for verification of multi-part data.

Testing:

Updated/expanded testing around cmac.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 8, 2025 16:02
@justsmth justsmth requested a review from skmcgrail December 8, 2025 16:03
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.62%. Comparing base (c358484) to head (5706fee).
⚠️ Report is 297 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/cmac.rs 94.44% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #968 +/- ## ========================================== - Coverage 95.80% 92.62% -3.18%  ========================================== Files 61 74 +13 Lines 8143 9982 +1839 Branches 0 9982 +9982 ========================================== + Hits 7801 9246 +1445  - Misses 342 452 +110  - Partials 0 284 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@justsmth justsmth merged commit 6ecc4e7 into aws:main Dec 9, 2025
388 of 397 checks passed
@justsmth justsmth deleted the cmac-sign-to-buffer branch December 9, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants