Report profile before sample to avoid incorrect profile end time #15 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits February 26, 2021 15:14
As we are using the last sample time as end time, there is chance we have the start time equals to end time.
mirelap-amazon approved these changes Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#15
Description of changes:
Make profile reporter to report profile before taking the sample to avoid scenario listed in issue #15 .
Also, avoid using the report time as profile end time which also a measure to avoid producing misleading data in scenario listed in issue #15
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.