- Notifications
You must be signed in to change notification settings - Fork 54
[CI] Update to Swift 6 CI #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
.github/workflows/pull_request.yml Outdated
jobs: | ||
soundness: | ||
name: Soundness | ||
uses: apple/swift-nio/.github/workflows/soundness.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be switched to the reusable one?
.github/workflows/scheduled.yml Outdated
jobs: | ||
unit-tests: | ||
name: Unit tests | ||
uses: apple/swift-nio/.github/workflows/unit_tests.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the other one but this one is correct
# Motivation We just updated our CI matrix in NIO to only support 5.9, 5.10 and 6. # Modification This PR updates the trigger files in this repo. Since this repo was always 5.9+ this is easy. # Result Up to date CI
33748f4
to 60f808c
Compare @czechboy0 @simonjbeaumont the documentation pipeline seems to be failing since switching over to the reusable repo updated the toolchain for that workflow from 5.10 to 6.0. It looks like there are some new warnings now that need to be fixed. Could you help me with that? |
Yes let me open a separate PR making those fixes first. |
@FranzBusch Actually, we have a chicken-and-egg problem, you need to bring this tiny diff into your PR instead, I can't merge mine with green CI anyway: #123 |
@czechboy0 Thanks for that. I slightly tweaked your commit to also avoid the |
@FranzBusch So the YAML linter still fails: |
@czechboy0 fixed! |
I still see it as failing 😬 |
8561e1d
to 141bf89
Compare 141bf89
to 4320d3e
Compare @czechboy0 Finally it's all green. Please do me the honours! |
Motivation
We just updated our CI matrix in NIO to only support 5.9, 5.10 and 6.
Modification
This PR updates the trigger files in this repo. Since this repo was always 5.9+ this is easy.
Result
Up to date CI