[Generator] Improve parameter handling of MIME types in content types #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
simonjbeaumont approved these changes Nov 28, 2024
czechboy0 added 🔨 semver/patch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation
The generator piece of apple/swift-openapi-runtime#113.
This is needed for APIs such as Kubernetes, that has both
application/jsonandapplication/json; watch=truein a single operation.Currently the parameters weren't taken into account, which could lead to incorrect matching of content types.
Modifications
Use the full MIME type, including the parameters, for matching.
Result
More correct behavior, now we correctly handle multiple MIME types with the same type/subtype in an operation.
Test Plan
Added a unit test.