This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Call onCompleted with data from cache #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Thanks for taking an initial pass at this @olistic! I'm going to make a few adjustments to this PR, then we'll get this merged shortly. |
Contributor Author
| @hwillson Cool! If there's anything else I could do to help, it'd be a pleasure. Just let me know, and anyway, I'll keep an eye on the PR so I learn a bit more about the codebase. |
Adjusts `<Query />` `onCompleted` and `onError` callbacks to be triggered via the `componentDidUpdate` lifecycle method. This ensures these callbacks can be used when data is fetched over the network, and when data is fetched from the local store (previsouly these callbacks were only being triggered when data was fetched over the network).
ghost mentioned this pull request 
Contributor
| I spent like 10 hours finding the cause of a regression caused by this 😔 Apollo is not using semver? This should have been either marked as a breaking change or be opt-in via prop considering there is no way to keep the previous behaviour |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a first attempt to fix #2177. If there's data at the time the
Querycomponent mounts,onCompletedwill be called.I'm not sure if this is the right direction. If anyone could take a look and let me know what they think I'd really appreciate it. If the changes are good, I'll put some effort into fixing the tests and writing new ones.
Thanks!