[MDEP-957] By default, don't report slf4j-simple as unused #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| */ | ||
| @Parameter | ||
| private String[] ignoredUnusedDeclaredDependencies = new String[0]; | ||
| private String[] ignoredUnusedDeclaredDependencies = {"org.slf4j:slf4j-simple::"}; |
There was a problem hiding this comment.
- why not use a
defaultoption of parameter? - when user defined another ignores list it will be overridden ... maybe we need add it latter to be always ignored ...
There was a problem hiding this comment.
A little later in the file I see this comment
// defaultValue value on @Parameter - not work with Maven 3.2.5 // When is set defaultValue always win, and there is no possibility to override by plugin configuration. Comment on lines 232 to 233
| * By default, org.slf4j:slf4j-simple is ignored. Setting this property to an empty list | ||
| * will allow it to be detected. |
There was a problem hiding this comment.
also setting to something else will detect slf4j-simple again
There was a problem hiding this comment.
I took this comment out. The doc generator will pick up the default value here and document it.
michael-o approved these changes Oct 16, 2024
| Resolve #1462 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
slf4j-simple is a super common "unused" dependency because when slfj-api or slf4j-impl is included and slf4j-simple isn't, the application works just fine but prints an annoying log message to the console telling developers to add it.
or
so devs deliberately add slf4j-simple to their dependencies just to shut up these warnings.
see https://www.slf4j.org/manual.html