[MDEP-689] Fixes ignored dependency filtering in go-offline goal

[ldhardy]

Duplicate issues MDEP-725 and MDEP-568

$ mvn -B dependency:go-offline -DexcludeGroupIds=org.dojotoolkit -DexcludeClassifiers=distribution -DexcludeArtifactIds=org.dojotoolkit:dojo:zip:1.10.8,dojo -DexcludeTypes=zip 

Results in attempted resolution of all of the excluded parameters. Looking at the GoOfflineMojo class, the filters were clearly never wired into the doExecute logic. This PR fixes that and adds some unit and integration tests.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[slawekjaranowski]

We are working on get rid of m-artifact-trafsfer - MDEP-858
but change looks ok.

[slawekjaranowski]

duplicate code

[ldhardy]

Do you know what is required to get a Jira account so I can make comments on the tickets? I've tried emailing various aliases and done the self-serve account request with no luck. It's been almost 2 months since my request.

I'll work on addressing your comments here in the next week or so.

We are working on get rid of m-artifact-trafsfer

I'm not sure how this relates to this PR, can you give me more info about what you mean?

[mthmulders]

I've tried emailing various aliases and done the self-serve account request with no luck.

Apologies, that one must've slipped through. I approved your self-serve account request a minute ago.

[slawekjaranowski]

Do you know what is required to get a Jira account so I can make comments on the tickets? I've tried emailing various aliases and done the self-serve account request with no luck. It's been almost 2 months since my request.

I'll work on addressing your comments here in the next week or so.

We are working on get rid of m-artifact-trafsfer

I'm not sure how this relates to this PR, can you give me more info about what you mean?

get rid of m-artifact-transfer it is not addressed by this PR
simply we add new code which use m-artifact-transfer .. but it is accepted for me now ... only please try to eliminate duplicate codes

commnts addressed

[elharo]

@slawekjaranowski Can we go ahead and merge this one?

[jira-importer]

Resolve #1199

[mschaefers]

any idea when this fix will be released?

[slawekjaranowski]

any idea when this fix will be released?

I hope in next week ... 😄